Skip to content

Conversation

@denpiligrim
Copy link
Contributor

@denpiligrim denpiligrim commented Mar 22, 2025

PR-Codex overview

This PR adds support for the ru_RU locale in the thirdweb package, enhancing the localization capabilities of the application by including Russian translations across various components.

Detailed summary

  • Added ru_RU locale to packages/thirdweb/src/react/web/ui/types.ts.
  • Implemented Russian translations in:
    • ConnectWallet component.
    • InjectedWallet component.
    • SmartWallet component.
  • Created ru.ts files for ConnectWallet, InjectedWallet, and SmartWallet with appropriate translations.
  • Updated test files to include ru_RU locale.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denpiligrim denpiligrim requested review from a team as code owners March 22, 2025 20:04
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Mar 22, 2025

@denpiligrim is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 22, 2025
@@ -0,0 +1,5 @@
---
"thirdweb": major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a patch please

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2025

🦋 Changeset detected

Latest commit: 1565f76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@denpiligrim denpiligrim changed the title [SDK] Feature: added ru_RU locale to SmartWallet component [SDK] Feature: added ru_RU locale to thirdweb package Mar 30, 2025
@catalyst17
Copy link
Contributor

catalyst17 commented Apr 1, 2025

@denpiligrim overall looks good, added some translations suggestions
thanks for contributing!

@denpiligrim denpiligrim requested a review from catalyst17 April 1, 2025 18:54
@joaquim-verges joaquim-verges merged commit d6373b2 into thirdweb-dev:main Apr 2, 2025
22 of 28 checks passed
@joaquim-verges joaquim-verges mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants